[Intel-gfx] [PATCH] drm/i915/mtl: Wa_22011802037: don't complain about missing regs on MTL

[Andrzej Hajda]

On 25.01.2023 00:11, Umesh Nerlige Ramappa wrote:
> From: John Harrison <John.C.Harrison at Intel.com>
> 
> Wa_22011802037 requires waiting for an engine-specific register to
> clear. A missing entry for GSC engine in the register table is flagged
> as a drm_err. The drm_err was originally intended to catch missing
> register entries for newer engines, however, it was later found that the
> WA is only required for 'legacy' engines. So just drop the drm_err.
> 
> Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_engine_cs.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index 922f1bb22dc6..f99bcc2113cb 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -1584,11 +1584,8 @@ static u32 __cs_pending_mi_force_wakes(struct intel_engine_cs *engine)
>   	};
>   	u32 val;
>   
> -	if (!_reg[engine->id].reg) {
> -		drm_err(&engine->i915->drm,
> -			"MSG IDLE undefined for engine id %u\n", engine->id);
> +	if (!_reg[engine->id].reg)
>   		return 0;
> -	}

While at it you can convert to i915_mmio_reg_valid.
With or without this:
Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej

>   
>   	val = intel_uncore_read(engine->uncore, _reg[engine->id]);
>