[Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations

Jani Nikula jani.nikula at intel.com
Tue Jun 27 07:53:01 UTC 2023


On Thu, 22 Jun 2023, Andi Shyti <andi.shyti at linux.intel.com> wrote:
> Hi Jani,
>
> On Wed, Jun 21, 2023 at 09:38:05PM +0300, Jani Nikula wrote:
>> Convert the raw_reg_read() and raw_reg_write() calls in display GU MISC
>> and INT CTL handling to regular intel_uncore_read() and
>> intel_uncore_write(). These were neglible micro-optimizations, and
>
> /neglible/negligible/
>
>> removing them helps the display code reuse in the Xe driver.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 

Thanks, but back to the drawing board:

https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119703v1/bat-dg2-9/igt@i915_pm_rpm@module-reload.html#dmesg-warnings1253

>
> Andi

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list