[Intel-gfx] [PATCH] drm/i915/display: remove display raw reg read/write micro-optimizations

[Andi Shyti]

Hi Jani,

On Tue, Jun 27, 2023 at 10:53:01AM +0300, Jani Nikula wrote:
> On Thu, 22 Jun 2023, Andi Shyti <andi.shyti at linux.intel.com> wrote:
> > Hi Jani,
> >
> > On Wed, Jun 21, 2023 at 09:38:05PM +0300, Jani Nikula wrote:
> >> Convert the raw_reg_read() and raw_reg_write() calls in display GU MISC
> >> and INT CTL handling to regular intel_uncore_read() and
> >> intel_uncore_write(). These were neglible micro-optimizations, and
> >
> > /neglible/negligible/
> >
> >> removing them helps the display code reuse in the Xe driver.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> >
> > Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com> 
> 
> Thanks, but back to the drawing board:
> 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_119703v1/bat-dg2-9/igt@i915_pm_rpm@module-reload.html#dmesg-warnings1253

Have you tried using intel_uncore_{read,write}_fw()?

Andi