[Intel-gfx] [PATCH 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array

[Joel Granados]

On Sat, Sep 30, 2023 at 05:52:17PM +0100, Phillip Potter wrote:
> On Fri, Sep 29, 2023 at 02:17:30PM +0200, Joel Granados wrote:
> > On Thu, Sep 28, 2023 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, Sep 28, 2023 at 03:21:26PM +0200, Joel Granados via B4 Relay wrote:
> > > > From: Joel Granados <j.granados at samsung.com>
> > > > 
> > > > This commit comes at the tail end of a greater effort to remove the
> > > > empty elements at the end of the ctl_table arrays (sentinels) which
> > > > will reduce the overall build time size of the kernel and run time
> > > > memory bloat by ~64 bytes per sentinel (further information Link :
> > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> > > > 
> > > > Remove sentinel element from cdrom_table
> > > > 
> > > > Signed-off-by: Joel Granados <j.granados at samsung.com>
> > > > ---
> > > >  drivers/cdrom/cdrom.c | 3 +--
> > > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > > 
> > > > diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> > > > index cc2839805983..451907ade389 100644
> > > > --- a/drivers/cdrom/cdrom.c
> > > > +++ b/drivers/cdrom/cdrom.c
> > > > @@ -3654,8 +3654,7 @@ static struct ctl_table cdrom_table[] = {
> > > >  		.maxlen		= sizeof(int),
> > > >  		.mode		= 0644,
> > > >  		.proc_handler	= cdrom_sysctl_handler
> > > > -	},
> > > > -	{ }
> > > > +	}
> > > 
> > > You should have the final entry as "}," so as to make any future
> > > additions to the list to only contain that entry, that's long been the
> > > kernel style for lists like this.
> > Will send a V2 with this included. Thx.
> > 
> > > 
> > > So your patches will just remove one line, not 2 and add 1, making it a
> > > smaller diff.
> > indeed.
> > 
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > -- 
> > 
> > Joel Granados
> 
> Hi Joel,
> 
> Thank you for your patch. I look forward to seeing V2, and will be happy
> to review it.
Am following a reported oops. Once I straighten that out, I'll send out
a V2

Bet

> 
> Regards,
> Phil

-- 

Joel Granados
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20231002/d2de5cce/attachment.sig>