[Intel-gfx] [PATCH v5 1/4] drm/i915: Add GuC TLB Invalidation pci tags

[Matt Roper]

On Wed, Oct 04, 2023 at 09:24:12PM +0200, Andi Shyti wrote:
> Hi John,
> 
> > > > Add pci (device info) tags for if GuC TLB Invalidation is enabled.
> > > > Since GuC based TLB invalidation is only strictly necessary for MTL
> > > > resently, only enable GuC based TLB invalidations for MTL.
> > > > 
> > > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> > > Jani was mentioning that the pci tags is not a proper title.
> > > 
> > > No need to resend, I think I will merge this series, so that, if
> > > you agree, I can change /pci tags/pci flag/ before pushing.
> > Have all the review comments been addressed? Surely it can't be pushed until
> > it has at least an ack from everyone who has expressed concerns about the
> > changes?
> 
> this particular patch did not receive any comment so far, except
> for the "pci tags" from Jani.
> 
> This solution was somehow hinted by Tvrtko in one of the previous
> review, I guess.
> 
> Personally I think that having a pci flag just for this is a bit
> of an overkill, but I don't have a strong opinion about it.

Drive-by comment:  you probably only want to turn on the feature flag
for MTL at the end of the series, not at the beginning.  Otherwise
bisects that land somewhere in the middle might have half the necessary
changes but not all of them.


Matt

> 
> Andi

-- 
Matt Roper
Graphics Software Engineer
Linux GPU Platform Enablement
Intel Corporation