[Intel-gfx] [PATCH v5 1/4] drm/i915: Add GuC TLB Invalidation pci tags

Andi Shyti andi.shyti at linux.intel.com
Wed Oct 4 19:47:01 UTC 2023


> > > > Add pci (device info) tags for if GuC TLB Invalidation is enabled.
> > > > Since GuC based TLB invalidation is only strictly necessary for MTL
> > > > resently, only enable GuC based TLB invalidations for MTL.
> > > > 
> > > > Signed-off-by: Jonathan Cavitt <jonathan.cavitt at intel.com>
> > > Jani was mentioning that the pci tags is not a proper title.
> > > 
> > > No need to resend, I think I will merge this series, so that, if
> > > you agree, I can change /pci tags/pci flag/ before pushing.
> > Have all the review comments been addressed? Surely it can't be pushed until
> > it has at least an ack from everyone who has expressed concerns about the
> > changes?

and... of course... I won't push it until all the reviews and
acks are in place... I just wanted to save Jonathan a v6 just for
this change if, in a furtunate case, there won't be other
reviews. 

Andi

> this particular patch did not receive any comment so far, except
> for the "pci tags" from Jani.
> 
> This solution was somehow hinted by Tvrtko in one of the previous
> review, I guess.
> 
> Personally I think that having a pci flag just for this is a bit
> of an overkill, but I don't have a strong opinion about it.
> 
> Andi


More information about the Intel-gfx mailing list