[Intel-gfx] [PATCH v2] drm/i915/mcr: Hold GT forcewake during steering operations

Andi Shyti andi.shyti at linux.intel.com
Tue Oct 24 15:29:33 UTC 2023


Hi Matt,

...

> > Cc: <stable at vger.kernel.org> # v6.3+
> 
> No stable kernels support MTL (even if they have some of the commits,
> it's all dead code).  We don't want to tag things for stable if they
> don't meet the stable kernel requirements.

yes, right... how could I have missed that :-D

> > When the access to the hardware was added.
> > 
> > BTW, given that currently we hold the forcewake already, is this
> > really a fix or is this more looking at the future? Is the Fixes
> > tag necessary?
> 
> I'm not 100% sure we hold forcewake in all the cases where we work with
> MCR registers.  For example, some of the big ones like wa_list_apply()
> don't grab forcewake until after we've already acquired the MCR
> semaphore.

yeah... OK!

> > Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

This stands.

Thanks, Matt!

Andi


More information about the Intel-gfx mailing list