✗ Fi.CI.CHECKPATCH: warning for drm/i915: Dump DSC HW state

Patchwork patchwork at emeril.freedesktop.org
Mon Aug 5 15:51:05 UTC 2024


== Series Details ==

Series: drm/i915: Dump DSC HW state
URL   : https://patchwork.freedesktop.org/series/136890/
State : warning

== Summary ==

Error: dim checkpatch failed
48090026fcb9 drm/i915: Replace to_bpp_x16() with fxp_q4_from_int()
2f3bb8ac464d drm/i915: Replace to_bpp_int() with fxp_q4_to_int()
-:103: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#103: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2209:
+#define BPP_X16_ARGS(bpp_x16)	fxp_q4_to_int(bpp_x16), (to_bpp_frac(bpp_x16) * 625)

-:103: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bpp_x16' - possible side-effects?
#103: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2209:
+#define BPP_X16_ARGS(bpp_x16)	fxp_q4_to_int(bpp_x16), (to_bpp_frac(bpp_x16) * 625)

total: 1 errors, 0 warnings, 1 checks, 148 lines checked
2cd0ab1563b7 drm/i915: Replace to_bpp_int_roundup() with fxp_q4_to_int_roundup()
f87465bd1b11 drm/i915: Replace to_bpp_frac() with fxp_q4_to_frac()
-:29: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#29: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2204:
+#define BPP_X16_ARGS(bpp_x16)	fxp_q4_to_int(bpp_x16), (fxp_q4_to_frac(bpp_x16) * 625)

-:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'bpp_x16' - possible side-effects?
#29: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:2204:
+#define BPP_X16_ARGS(bpp_x16)	fxp_q4_to_int(bpp_x16), (fxp_q4_to_frac(bpp_x16) * 625)

total: 1 errors, 0 warnings, 1 checks, 38 lines checked
b01c8accd3a8 drm/i915: Replace BPP_X16_FMT()/ARGS() with FXP_Q4_FMT()/ARGS()
-:77: WARNING:MISSING_SPACE: break quoted strings at a space character
#77: FILE: drivers/gpu/drm/i915/display/intel_dp.c:2369:
 			    "Cannot compute valid DSC parameters for Input Bpp = %d"
+			    "Compressed BPP = " FXP_Q4_FMT "\n",

-:99: WARNING:LONG_LINE: line length of 163 exceeds 100 columns
#99: FILE: drivers/gpu/drm/i915/display/intel_dp.c:2432:
+		    "[ENCODER:%d:%s][CRTC:%d:%s] DP link limits: pixel clock %d kHz DSC %s max lanes %d max rate %d max pipe_bpp %d max link_bpp " FXP_Q4_FMT "\n",

total: 0 errors, 2 warnings, 0 checks, 98 lines checked
9f5642dbbd50 drm/i915: Dump DSC state to dmesg and debugfs/i915_display_info
9187a52309a5 drm/i915: Remove DSC register dump




More information about the Intel-gfx mailing list