[PATCH 4/5] drm/i915/pll_algorithm: Compute C10 HDMI PLLs with algorithm

[Nautiyal, Ankit K]

On 8/6/2024 7:29 PM, Jani Nikula wrote:
> On Tue, 06 Aug 2024, Ankit Nautiyal <ankit.k.nautiyal at intel.com> wrote:
>> diff --git a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h
>> index 9f60bd9bacbe..288289ec593f 100644
>> --- a/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h
>> +++ b/drivers/gpu/drm/i915/display/intel_snps_hdmi_pll.h
>> @@ -8,8 +8,10 @@
>>   
>>   #include <linux/types.h>
>>   
>> +struct intel_c10pll_state;
>>   struct intel_mpllb_state;
>>   
>>   void intel_snps_phy_compute_hdmi_tmds_pll(struct intel_mpllb_state *pll_state, u64 pixel_clock);
>> +void intel_c10_phy_compute_hdmi_tmds_pll(struct intel_c10pll_state *pll_state, u64 pixel_clock);
> If you have a file intel_snps_hdmi_pll.[ch], the functions should be
> named intel_snps_hdmi_pll_*().


Makes sense. I am considering having:

intel_snps_hdmi_compute_mpllb(), intel_snps_hdmi_compute_c10pll().

Also realized that the subject prefix also need to align with new names.

Will fix these in next version of the patch.


Thanks & Regard,

Ankit


>
> Or you need to rename the file.
>
> BR,
> Jani.
>
>>   
>>   #endif /* __INTEL_SNPS_HDMI_PLL_H__ */