✗ Fi.CI.CHECKPATCH: warning for CCS static load balance (rev2)

[Patchwork]

== Series Details ==

Series: CCS static load balance (rev2)
URL   : https://patchwork.freedesktop.org/series/136381/
State : warning

== Summary ==

Error: dim checkpatch failed
84e876cb3a32 drm/i915/gt: Move the CCS mode variable to a global position
-:113: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#113: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:226:
+		struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 95 lines checked
3b0bf8998852 drm/i915/gt: Allow the creation of multi-mode CCS masks
0076ce951e97 drm/i915/gt: Refactor uabi engine class/instance list creation
-:54: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#54: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:233:
+		GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance));

-:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#70: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:247:
+		GEM_BUG_ON(uabi_class >=

total: 0 errors, 2 warnings, 0 checks, 56 lines checked
96ff57617c4a drm/i915/gt: Manage CCS engine creation within UABI exposure
4743af1f0f34 drm/i915/gt: Remove cslices mask value from the CCS structure
12d784cbbf89 drm/i915/gt: Expose the number of total CCS slices
09c8acafca2a drm/i915/gt: Store engine-related sysfs kobjects
e2ea1fbf7f3b drm/i915/gt: Store active CCS mask
9d3afeca2efa drm/i915/gt: Isolate single sysfs engine file creation
-:100: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#100: FILE: drivers/gpu/drm/i915/gt/sysfs_engines.c:539:
+	gt_err(engine->gt, "Failed to add sysfs engine '%s'\n",
+		engine->name);

total: 0 errors, 0 warnings, 1 checks, 115 lines checked
54a64c3795dd drm/i915/gt: Implement creation and removal routines for CCS engines
be957e86b979 drm/i915/gt: Allow the user to change the CCS mode through sysfs
-:71: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!val'
#71: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:239:
+	if ((!val) || (val > num_cslices) || (num_cslices % val))

-:71: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'val > num_cslices'
#71: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:239:
+	if ((!val) || (val > num_cslices) || (num_cslices % val))

total: 0 errors, 0 warnings, 2 checks, 90 lines checked