✗ Fi.CI.CHECKPATCH: warning for CCS static load balance

Patchwork patchwork at emeril.freedesktop.org
Fri Aug 23 14:14:16 UTC 2024


== Series Details ==

Series: CCS static load balance
URL   : https://patchwork.freedesktop.org/series/137715/
State : warning

== Summary ==

Error: dim checkpatch failed
f36edbebc969 drm/i915/gt: Avoid using masked workaround for CCS_MODE setting
9744b72c26af drm/i915/gt: Move the CCS mode variable to a global position
a9ed0d3824af drm/i915/gt: Allow the creation of multi-mode CCS masks
083c104fa607 drm/i915/gt: Refactor uabi engine class/instance list creation
-:54: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#54: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:233:
+		GEM_BUG_ON(uabi_class >= ARRAY_SIZE(class_instance));

-:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#70: FILE: drivers/gpu/drm/i915/gt/intel_engine_user.c:247:
+		GEM_BUG_ON(uabi_class >=

total: 0 errors, 2 warnings, 0 checks, 56 lines checked
e5a08b266450 drm/i915/gem: Mark and verify UABI engine validity
2b9b405eede7 drm/i915/gt: Introduce for_each_enabled_engine() and apply it in selftests
-:30: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196:
+#define for_each_enabled_engine(engine__, gt__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_NUM_ENGINES; \
+	     (id__)++) \
+		for_each_if (((engine__) = (gt__)->engine[(id__)]) && \
+			     (!RB_EMPTY_NODE(&(engine__)->uabi_node)))

-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects?
#30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196:
+#define for_each_enabled_engine(engine__, gt__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_NUM_ENGINES; \
+	     (id__)++) \
+		for_each_if (((engine__) = (gt__)->engine[(id__)]) && \
+			     (!RB_EMPTY_NODE(&(engine__)->uabi_node)))

-:30: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'id__' - possible side-effects?
#30: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:196:
+#define for_each_enabled_engine(engine__, gt__, id__) \
+	for ((id__) = 0; \
+	     (id__) < I915_NUM_ENGINES; \
+	     (id__)++) \
+		for_each_if (((engine__) = (gt__)->engine[(id__)]) && \
+			     (!RB_EMPTY_NODE(&(engine__)->uabi_node)))

-:34: WARNING:SPACING: space prohibited between function name and open parenthesis '('
#34: FILE: drivers/gpu/drm/i915/gt/intel_gt.h:200:
+		for_each_if (((engine__) = (gt__)->engine[(id__)]) && \

total: 1 errors, 1 warnings, 2 checks, 738 lines checked
225f2e16a369 drm/i915/gt: Manage CCS engine creation within UABI exposure
641b8d9ba13c drm/i915/gt: Remove cslices mask value from the CCS structure
df72b5db7987 drm/i915/gt: Expose the number of total CCS slices
50847d494e8d drm/i915/gt: Store engine-related sysfs kobjects
575c97dc58c8 drm/i915/gt: Store active CCS mask
-:70: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#70: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:120:
+	GEM_BUG_ON(ccs_mode);

total: 0 errors, 1 warnings, 0 checks, 83 lines checked
a5f4f7b8ec59 drm/i915: Protect access to the UABI engines list with a mutex
d832e381b9a3 drm/i915/gt: Isolate single sysfs engine file creation
ac990eb960d8 drm/i915/gt: Implement creation and removal routines for CCS engines
-:119: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#119: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:206:
+		GEM_BUG_ON(rb_find_add(&e->uabi_node,

-:123: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#123: FILE: drivers/gpu/drm/i915/gt/intel_gt_ccs_mode.c:210:
+		GEM_BUG_ON(intel_engine_lookup_user(i915, e->uabi_class,

total: 0 errors, 2 warnings, 0 checks, 146 lines checked
ba1301876c47 drm/i915/gt: Allow the user to change the CCS mode through sysfs




More information about the Intel-gfx mailing list