[PATCH v2 11/86] drm/atmel-hdlcd: Run DRM default client setup

[Thomas Zimmermann]

Hi Sam

Am 23.08.24 um 20:51 schrieb Sam Ravnborg:
> On Wed, Aug 21, 2024 at 02:59:08PM +0200, Thomas Zimmermann wrote:
>> Call drm_client_setup_with_fourcc() to run the kernel's default client
>> setup for DRM. Set fbdev_probe in struct drm_driver, so that the client
>> setup can start the common fbdev client.
>>
>> v2:
>> - use drm_client_setup_with_fourcc()
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: Sam Ravnborg <sam at ravnborg.org>
>> Cc: Boris Brezillon <bbrezillon at kernel.org>
>> Cc: Nicolas Ferre <nicolas.ferre at microchip.com>
>> Cc: Alexandre Belloni <alexandre.belloni at bootlin.com>
>> Cc: Claudiu Beznea <claudiu.beznea at tuxon.dev>
> Hi Thomas.
>
>> ---
>>   drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> index 9ce429f889ca..ca5bde8ac300 100644
>> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c
>> @@ -18,8 +18,10 @@
>>   
>>   #include <drm/drm_atomic.h>
>>   #include <drm/drm_atomic_helper.h>
>> +#include <drm/drm_client_setup.h>
>>   #include <drm/drm_drv.h>
>>   #include <drm/drm_fbdev_dma.h>
>> +#include <drm/drm_fourcc.h>
>>   #include <drm/drm_gem_dma_helper.h>
>>   #include <drm/drm_gem_framebuffer_helper.h>
>>   #include <drm/drm_module.h>
>> @@ -865,7 +867,7 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
>>   	if (ret)
>>   		goto err_unload;
>>   
>> -	drm_fbdev_dma_setup(ddev, 24);
>> +	drm_client_setup_with_fourcc(ddev, DRM_FORMAT_RGB888);
>>   
>>   	return 0;
> I looks like a patch is missing to add DRM_FBDEV_DMA_DRIVER_OPS to
> struct drm_driver?

Indeed. Thanks a lot for proof reading. I'll double-check the other 
patches for the next iteration.

Best regards
Thomas

>
> 	Sam

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)