[PATCH 6/6] drm/i915/wm: Club the initialized variables together

[Kandpal, Suraj]

> -----Original Message-----
> From: Golani, Mitulkumar Ajitkumar
> <mitulkumar.ajitkumar.golani at intel.com>
> Sent: Thursday, December 5, 2024 7:29 AM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>; intel-xe at lists.freedesktop.org;
> intel-gfx at lists.freedesktop.org
> Subject: RE: [PATCH 6/6] drm/i915/wm: Club the initialized variables together
> 
> 
> 
> > -----Original Message-----
> > From: Kandpal, Suraj <suraj.kandpal at intel.com>
> > Sent: 03 December 2024 14:17
> > To: intel-xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
> > Cc: Golani, Mitulkumar Ajitkumar
> > <mitulkumar.ajitkumar.golani at intel.com>;
> > Kandpal, Suraj <suraj.kandpal at intel.com>
> > Subject: [PATCH 6/6] drm/i915/wm: Club the initialized variables
> > together
> >
> > Refactor program_dpkgc function so that all initialized variables are
> > clubbed together.
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal at intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c
> > b/drivers/gpu/drm/i915/display/skl_watermark.c
> > index 4c032b1758e7..d93f6786db0e 100644
> > --- a/drivers/gpu/drm/i915/display/skl_watermark.c
> > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c
> > @@ -2862,9 +2862,9 @@ intel_program_dpkgc_latency(struct
> > intel_atomic_state *state)
> >  	struct intel_crtc *crtc;
> >  	struct intel_crtc_state *new_crtc_state;
> >  	u32 latency = LNL_PKG_C_LATENCY_MASK;
> > +	u32 added_wake_time = 0;
> >  	u32 max_linetime = 0;
> >  	u32 clear, val;
> > -	u32 added_wake_time = 0;
> >  	bool fixed_refresh_rate = false;
> 
> If go by commit message words, change does not actually club all initialised
> params together and uninitialized separate.

So when we club params together it needs to be under these restriction
All with same type come together and the ones with same type with initialization need to be together

Regards,
Suraj Kandpal

> 
> >  	int i;
> >
> > --
> > 2.34.1