[PATCH v2 2/3] accel/ivpu: remove DRIVER_DATE conditional drm_driver init

Thomas Zimmermann tzimmermann at suse.de
Thu Dec 5 07:28:52 UTC 2024




Am 04.12.24 um 15:31 schrieb Jani Nikula:
> The ivpu struct drm_driver has conditional initialization based on #ifdef
> DRIVER_DATE, which is never defined anywhere. Neither are the macros
> referenced within the block: DRIVER_DATE, DRIVER_MAJOR, DRIVER_MINOR,
> and DRIVER_PATCHLEVEL. With the struct drm_driver date member going away
> anyway, just remove the conditional compilation.
>
> Acked-by: Alex Deucher <alexander.deucher at amd.com>
> Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Reviewed-by: Thomas Zimmermann <tzimmermann at suse.de>

>
> ---
>
> Note: I prefer to merge this together with the other patches via
> drm-misc-next.
>
> Cc: David Airlie <airlied at gmail.com>
> Cc: Jacek Lawrynowicz <jacek.lawrynowicz at linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: Oded Gabbay <ogabbay at kernel.org>
> Cc: Simona Vetter <simona at ffwll.ch>
> Cc: Stanislaw Gruszka <stanislaw.gruszka at linux.intel.com>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: dri-devel at lists.freedesktop.org
> ---
>   drivers/accel/ivpu/ivpu_drv.c | 7 -------
>   1 file changed, 7 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index ca2bf47ce248..1f359dbe5150 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -458,15 +458,8 @@ static const struct drm_driver driver = {
>   	.name = DRIVER_NAME,
>   	.desc = DRIVER_DESC,
>   
> -#ifdef DRIVER_DATE
> -	.date = DRIVER_DATE,
> -	.major = DRIVER_MAJOR,
> -	.minor = DRIVER_MINOR,
> -	.patchlevel = DRIVER_PATCHLEVEL,
> -#else
>   	.date = UTS_RELEASE,
>   	.major = 1,
> -#endif
>   };
>   
>   static void ivpu_context_abort_invalid(struct ivpu_device *vdev)

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)



More information about the Intel-gfx mailing list