[PATCH] drm/i915/pps: include panel power cycle delay in debugfs

Paul Menzel pmenzel at molgen.mpg.de
Fri Dec 6 11:17:34 UTC 2024


Dear Jani,


Thank you for the patch.

Am 05.12.24 um 13:37 schrieb Jani Nikula:
> The debugfs contains all the other timings except panel power cycle
> delay. Add it for completeness.

For the record, here is the output from the Dell XPS 13 9360, and in 
case you want to add it to the commit message.

     $ sudo more /sys/kernel/debug/dri/0000:00:02.0/eDP-1/i915_panel_timings
     Panel power up delay: 200
     Panel power down delay: 50
     Panel power cycle delay: 600
     Backlight on delay: 1
     Backlight off delay: 200

> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_pps.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_pps.c b/drivers/gpu/drm/i915/display/intel_pps.c
> index 7784b3b760db..e55c84685521 100644
> --- a/drivers/gpu/drm/i915/display/intel_pps.c
> +++ b/drivers/gpu/drm/i915/display/intel_pps.c
> @@ -1819,6 +1819,8 @@ static int intel_pps_show(struct seq_file *m, void *data)
>   		   intel_dp->pps.panel_power_up_delay);
>   	seq_printf(m, "Panel power down delay: %d\n",
>   		   intel_dp->pps.panel_power_down_delay);
> +	seq_printf(m, "Panel power cycle delay: %d\n",
> +		   intel_dp->pps.panel_power_cycle_delay);
>   	seq_printf(m, "Backlight on delay: %d\n",
>   		   intel_dp->pps.backlight_on_delay);
>   	seq_printf(m, "Backlight off delay: %d\n",

Tested-by: Paul Menzel <pmenzel at molgen.mpg.de> # Dell XPS 13 9360


Kind regards,

Paul


More information about the Intel-gfx mailing list