[PATCH v2 3/5] drm/i915/dp: convert to struct intel_display
Jani Nikula
jani.nikula at intel.com
Thu Dec 12 10:30:54 UTC 2024
On Thu, 12 Dec 2024, Luca Coelho <luca at coelho.fi> wrote:
> On Tue, 2024-12-10 at 12:46 +0200, Jani Nikula wrote:
>> Going forward, struct intel_display is the main device data structure
>> for display. Switch to it internally in DP code.
>>
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>> ---
>
> These huge mechanical changes are impossible to review fully with my
> attention span, but the patch looks sane. Again, if you used any
> semantic patch to do this, it would be easier to review it instead. ;)
I started off with a *huge* semantic patch which isn't easy to review
either... especially so because it falls short on a bunch of cases and
needs manual tweaking anyway.
I'm not sure what the return on investment is with tweaking the cocci,
because making changes to it ends up being a lot of trial and error. :(
> Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
Thanks,
Jani.
>
> --
> Cheers,
> Luca.
--
Jani Nikula, Intel
More information about the Intel-gfx
mailing list