[PATCH v2] i915/gt: Reapply workarounds in case the previous attempt failed.

Krzysztof Karas krzysztof.karas at intel.com
Wed Dec 18 14:30:02 UTC 2024


Hi Sebastian,

...
> +		/*
> +		 * Writing workarounds can sporadically fail,
> +		 * in which  case try to apply it again.
You have a double space here. Apart from that the patch looks good to
me.

Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>

Krzysztof

> +		 */
> +		uint repeat = 1;
>  
> -			wa_verify(gt, wa, val, wal->name, "application");
> -		}
> +		do {
> +			wa_write_fw(gt, wa);
> +		} while (!wa_verify(gt, wa, wa_read_fw(gt, wa), wal->name,
> +					"application")
> +			&& repeat--);
>  	}
>  
>  	intel_uncore_forcewake_put__locked(uncore, fw);
> @@ -1793,9 +1806,8 @@ static bool wa_list_verify(struct intel_gt *gt,
>  	intel_uncore_forcewake_get__locked(uncore, fw);
>  
>  	for (i = 0, wa = wal->list; i < wal->count; i++, wa++)
> -		ok &= wa_verify(wal->gt, wa, wa->is_mcr ?
> -				intel_gt_mcr_read_any_fw(gt, wa->mcr_reg) :
> -				intel_uncore_read_fw(uncore, wa->reg),
> +		ok &= wa_verify(wal->gt, wa,
> +				wa_read_fw(wal->gt, wa),
>  				wal->name, from);
>  
>  	intel_uncore_forcewake_put__locked(uncore, fw);
> -- 
> 2.34.1
> 


More information about the Intel-gfx mailing list