[PATCH 1/8] drm/i915/scaler: Extract skl_scaler_min_src_size()

Luca Coelho luca at coelho.fi
Fri Dec 20 08:47:24 UTC 2024


On Thu, 2024-12-19 at 15:08 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The SKL_MIN_*SRC_* defines just make things hard to read.
> Get rid of them and introduce an easy to read function
> in their place.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---

Looks good, but a small nitpick: maybe you want to mention in the
commit message that you're not returning -EINVAL anymore, but using
defaults (8x8) in the YUV with too-small-source case? Up to you.

Reviewed-by: Luca Coelho <luciano.coelho at intel.com>

--
Cheers,
Luca.


More information about the Intel-gfx mailing list