[PATCH 6/8] drm/i915/scaler: Pimp scaler debugs
Luca Coelho
luca at coelho.fi
Fri Dec 20 08:55:02 UTC 2024
On Thu, 2024-12-19 at 15:08 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Include the standard "[CRTC:...]" information in the scaler debugs
> to make life easier.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/skl_scaler.c | 25 +++++++++++++++--------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_scaler.c b/drivers/gpu/drm/i915/display/skl_scaler.c
> index cbc71e44fcbb..f6d76ef1a854 100644
> --- a/drivers/gpu/drm/i915/display/skl_scaler.c
> +++ b/drivers/gpu/drm/i915/display/skl_scaler.c
> @@ -166,7 +166,8 @@ skl_update_scaler(struct intel_crtc_state *crtc_state, bool force_detach,
> if (DISPLAY_VER(display) >= 9 && crtc_state->hw.enable &&
> need_scaler && adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
> drm_dbg_kms(display->drm,
> - "Pipe/Plane scaling not supported with IF-ID mode\n");
> + "[CRTC:%d:%s] scaling not supported with IF-ID mode\n",
> + crtc->base.base.id, crtc->base.name);
You're losing the "Pipe/Plane" string from this log, which could cause
issues if anyone is grepping for it in some scripts, but it seems
redundant to me anyway, so scripts (if any) should be fixed instead. ;)
Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
--
Cheers,
Luca.
More information about the Intel-gfx
mailing list