[PATCH] drm/i915/gt: Prevent uninitialized pointer reads

Krzysztof Karas krzysztof.karas at intel.com
Mon Dec 30 14:26:15 UTC 2024


Hi Apoorva,

> From: Apoorva Singh <apoorva.singh at intel.com>
> 
> Initialize rq to NULL to prevent uninitialized pointer reads.
> 
> Signed-off-by: Apoorva Singh <apoorva.singh at intel.com>
> ---
>  drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/selftest_migrate.c b/drivers/gpu/drm/i915/gt/selftest_migrate.c
> index ca460cee4f8b..1bf7b88d9a9d 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_migrate.c
> @@ -262,7 +262,7 @@ static int clear(struct intel_migrate *migrate,
>  {
>  	struct drm_i915_private *i915 = migrate->context->engine->i915;
>  	struct drm_i915_gem_object *obj;
> -	struct i915_request *rq;
> +	struct i915_request *rq = NULL;
>  	struct i915_gem_ww_ctx ww;
>  	u32 *vaddr, val = 0;
>  	bool ccs_cap = false;
> -- 
> 2.34.1

Looks good to me

Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>

Krzysztof



More information about the Intel-gfx mailing list