[PATCHv2 2/5] drm/i915/display: histogram interrupt handling

Murthy, Arun R arun.r.murthy at intel.com
Thu Sep 12 09:52:06 UTC 2024


> > +static void intel_histogram_handle_int_work(struct work_struct *work) {
> > +	struct intel_histogram *histogram = container_of(work,
> > +		struct intel_histogram, handle_histogram_int_work.work);
> > +	struct drm_i915_private *i915 = histogram->i915;
> > +	struct intel_crtc *intel_crtc = histogram->crtc;
> > +	char *histogram_event[] = {"HISTOGRAM=1", NULL};
> > +	u32 dpstbin;
> > +	int i, try = 0;
> > +
> If we have PSR enabled looks like this code might straight away break, and PSR
> being enabled is a common scenario Can we have some checks on enabling this
> feature if no PSR until we handle this scenario?

With PSR enabled histogram event will not be generated as there wont be any statistics.
This should have no impact to user and user is not time bound with the histogram event.

This TODO is to handle the histogram generation even in case of PSR enabled with some additional settings.

Thanks and Regards,
Arun R Murthy
-------------------


More information about the Intel-gfx mailing list