[PATCHv2 2/5] drm/i915/display: histogram interrupt handling

[Kulkarni, Vandita]

> -----Original Message-----
> From: Murthy, Arun R <arun.r.murthy at intel.com>
> Sent: Thursday, September 12, 2024 3:22 PM
> To: Kulkarni, Vandita <vandita.kulkarni at intel.com>; intel-
> gfx at lists.freedesktop.org
> Subject: RE: [PATCHv2 2/5] drm/i915/display: histogram interrupt handling
> 
> > > +static void intel_histogram_handle_int_work(struct work_struct *work)
> {
> > > +	struct intel_histogram *histogram = container_of(work,
> > > +		struct intel_histogram, handle_histogram_int_work.work);
> > > +	struct drm_i915_private *i915 = histogram->i915;
> > > +	struct intel_crtc *intel_crtc = histogram->crtc;
> > > +	char *histogram_event[] = {"HISTOGRAM=1", NULL};
> > > +	u32 dpstbin;
> > > +	int i, try = 0;
> > > +
> > If we have PSR enabled looks like this code might straight away break,
> > and PSR being enabled is a common scenario Can we have some checks on
> > enabling this feature if no PSR until we handle this scenario?
> 
> With PSR enabled histogram event will not be generated as there wont be
> any statistics.
> This should have no impact to user and user is not time bound with the
> histogram event.

Just to get some clarity, does this mean the tests for histogram wont  fail on PSR enabled panel with this series ?

Thanks,
Vandita
> 
> This TODO is to handle the histogram generation even in case of PSR enabled
> with some additional settings.
> 
> Thanks and Regards,
> Arun R Murthy
> -------------------