[PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT
Srikanth V, NagaVenkata
nagavenkata.srikanth.v at intel.com
Thu Sep 12 12:01:27 UTC 2024
Hi Jani,
AUX_RD interval can have maximum value of 256ms. usleep_range() is recommended to be used for 10uS-20ms range as per Documentation/timers/timers-howto.rst
[cid:image001.png at 01DB0539.9751B230]
So, switched to fsleep() which takes care of calling respective functions according to the delay.
Regards
Srikanth
-----Original Message-----
From: Murthy, Arun R <arun.r.murthy at intel.com>
Sent: Thursday, September 12, 2024 3:34 PM
To: Jani Nikula <jani.nikula at linux.intel.com>; intel-xe at lists.freedesktop.org; intel-gfx at lists.freedesktop.org
Cc: Srikanth V, NagaVenkata <nagavenkata.srikanth.v at intel.com>
Subject: RE: [PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT
> -----Original Message-----
> From: Jani Nikula <jani.nikula at linux.intel.com<mailto:jani.nikula at linux.intel.com>>
> Sent: Thursday, September 12, 2024 2:32 PM
> To: Murthy, Arun R <arun.r.murthy at intel.com<mailto:arun.r.murthy at intel.com>>;
> intel-xe at lists.freedesktop.org<mailto:intel-xe at lists.freedesktop.org>; intel-gfx at lists.freedesktop.org<mailto:intel-gfx at lists.freedesktop.org>
> Cc: Murthy, Arun R <arun.r.murthy at intel.com<mailto:arun.r.murthy at intel.com>>; Srikanth V, NagaVenkata
> <nagavenkata.srikanth.v at intel.com<mailto:nagavenkata.srikanth.v at intel.com>>
> Subject: Re: [PATCH 1/3] drm/i915/dp: use fsleep instead of
> usleep_rage for LT
>
> On Thu, 12 Sep 2024, Arun R Murthy <arun.r.murthy at intel.com<mailto:arun.r.murthy at intel.com>> wrote:
> > Aux RD Interval value depends on the value read from the dpcd
> > register which is updated from the sink device use flseep thereby we
> > adhere to the Documentation/timers/timers-howto.rst
>
> Please explain why instead of just referencing a file.
Sleeping for < 10us use udelay, for 10us to 20ms use usleep_range and for > 10ms use msleep.
fsleep() will call the particular api based on the above condition.
Thanks and Regards,
Arun R Murthy
--------------------
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20240912/a27d31dd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 94921 bytes
Desc: image001.png
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20240912/a27d31dd/attachment-0001.png>
More information about the Intel-gfx
mailing list