[PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT
Jani Nikula
jani.nikula at linux.intel.com
Mon Sep 23 10:23:41 UTC 2024
On Thu, 12 Sep 2024, "Murthy, Arun R" <arun.r.murthy at intel.com> wrote:
>> -----Original Message-----
>> From: Jani Nikula <jani.nikula at linux.intel.com>
>> Sent: Thursday, September 12, 2024 2:32 PM
>> To: Murthy, Arun R <arun.r.murthy at intel.com>; intel-xe at lists.freedesktop.org;
>> intel-gfx at lists.freedesktop.org
>> Cc: Murthy, Arun R <arun.r.murthy at intel.com>; Srikanth V, NagaVenkata
>> <nagavenkata.srikanth.v at intel.com>
>> Subject: Re: [PATCH 1/3] drm/i915/dp: use fsleep instead of usleep_rage for LT
>>
>> On Thu, 12 Sep 2024, Arun R Murthy <arun.r.murthy at intel.com> wrote:
>> > Aux RD Interval value depends on the value read from the dpcd register
>> > which is updated from the sink device use flseep thereby we adhere to
>> > the Documentation/timers/timers-howto.rst
>>
>> Please explain why instead of just referencing a file.
>
> Sleeping for < 10us use udelay, for 10us to 20ms use usleep_range and for > 10ms use msleep.
> fsleep() will call the particular api based on the above condition.
Oh, I'm not asking to explain this specifically to me. I'm asking it to
be explained in the commit message, for posterity. A commit message
should always answer the question *why*.
BR,
Jani.
--
Jani Nikula, Intel
More information about the Intel-gfx
mailing list