RE: ✗ Fi.CI.BUILD: failure for Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from check_link"

[Bhadane, Dnyaneshwar]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of
> Patchwork
> Sent: Friday, December 20, 2024 10:52 AM
> To: Kandpal, Suraj <suraj.kandpal at intel.com>
> Cc: intel-gfx at lists.freedesktop.org
> Subject: ✗ Fi.CI.BUILD: failure for Revert "drm/i915/hdcp: Don't enable
> HDCP1.4 directly from check_link"
> 
> == Series Details ==
> 
> Series: Revert "drm/i915/hdcp: Don't enable HDCP1.4 directly from
> check_link"
> URL   : https://patchwork.freedesktop.org/series/142871/
> State : failure
> 
> == Summary ==
> 
> Error: make failed
>   CALL    scripts/checksyscalls.sh
>   DESCEND objtool
>   INSTALL libsubcmd_headers
>   CC [M]  drivers/gpu/drm/i915/display/intel_hdcp.o
> In file included from ./include/linux/device.h:15,
>                  from ./include/linux/acpi.h:14,
>                  from ./include/linux/i2c.h:13,
>                  from drivers/gpu/drm/i915/display/intel_hdcp.c:12:
> drivers/gpu/drm/i915/display/intel_hdcp.c: In function
> ‘intel_hdcp_check_link’:
> drivers/gpu/drm/i915/display/intel_hdcp.c:1171:26: error: ‘i915’ undeclared
> (first use in this function); did you mean ‘I915’?
>  1171 |                 drm_err(&i915->drm, "Failed to enable hdcp (%d)\n", ret);
>       |                          ^~~~
> ./include/linux/dev_printk.h:110:25: note: in definition of macro
> ‘dev_printk_index_wrap’
>   110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
>       |                         ^~~
> ./include/drm/drm_print.h:588:9: note: in expansion of macro ‘dev_err’
>   588 |         dev_##level##type((drm) ? (drm)->dev : NULL, "[drm] " fmt,
> ##__VA_ARGS__)
>       |         ^~~~
> ./include/drm/drm_print.h:601:9: note: in expansion of macro ‘__drm_printk’
>   601 |         __drm_printk((drm), err,, "*ERROR* " fmt, ##__VA_ARGS__)
>       |         ^~~~~~~~~~~~
> drivers/gpu/drm/i915/display/intel_hdcp.c:1171:17: note: in expansion of
> macro ‘drm_err’
>  1171 |                 drm_err(&i915->drm, "Failed to enable hdcp (%d)\n", ret);
Hi Suraj, 

The intel_hdcp_check_link() code no longer use &i915->drm.
Please use the intel_display structure instead.

Regards, 
Dnyaneshwar

>       |                 ^~~~~~~
> drivers/gpu/drm/i915/display/intel_hdcp.c:1171:26: note: each undeclared
> identifier is reported only once for each function it appears in
>  1171 |                 drm_err(&i915->drm, "Failed to enable hdcp (%d)\n", ret);
>       |                          ^~~~
> ./include/linux/dev_printk.h:110:25: note: in definition of macro
> ‘dev_printk_index_wrap’
>   110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
>       |                         ^~~
> ./include/drm/drm_print.h:588:9: note: in expansion of macro ‘dev_err’
>   588 |         dev_##level##type((drm) ? (drm)->dev : NULL, "[drm] " fmt,
> ##__VA_ARGS__)
>       |         ^~~~
> ./include/drm/drm_print.h:601:9: note: in expansion of macro ‘__drm_printk’
>   601 |         __drm_printk((drm), err,, "*ERROR* " fmt, ##__VA_ARGS__)
>       |         ^~~~~~~~~~~~
> drivers/gpu/drm/i915/display/intel_hdcp.c:1171:17: note: in expansion of
> macro ‘drm_err’
>  1171 |                 drm_err(&i915->drm, "Failed to enable hdcp (%d)\n", ret);
>       |                 ^~~~~~~
> make[6]: *** [scripts/Makefile.build:194:
> drivers/gpu/drm/i915/display/intel_hdcp.o] Error 1
> make[5]: *** [scripts/Makefile.build:440: drivers/gpu/drm/i915] Error 2
> make[4]: *** [scripts/Makefile.build:440: drivers/gpu/drm] Error 2
> make[3]: *** [scripts/Makefile.build:440: drivers/gpu] Error 2
> make[2]: *** [scripts/Makefile.build:440: drivers] Error 2
> make[1]: *** [/home/kbuild/kernel/Makefile:1989: .] Error 2
> make: *** [Makefile:251: __sub-make] Error 2 Build failed, no error log
> produced
>