[PATCH 1/8] drm/i915/scaler: Extract skl_scaler_min_src_size()

[Ville Syrjälä]

On Fri, Dec 20, 2024 at 10:47:24AM +0200, Luca Coelho wrote:
> On Thu, 2024-12-19 at 15:08 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > The SKL_MIN_*SRC_* defines just make things hard to read.
> > Get rid of them and introduce an easy to read function
> > in their place.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> 
> Looks good, but a small nitpick: maybe you want to mention in the
> commit message that you're not returning -EINVAL anymore, but using
> defaults (8x8) in the YUV with too-small-source case? Up to you.

It will still return -EINVAL for < 16x16 YUV cases.

> 
> Reviewed-by: Luca Coelho <luciano.coelho at intel.com>
> 
> --
> Cheers,
> Luca.

-- 
Ville Syrjälä
Intel