[PATCH v2] drm/i915/selftests: avoid using uninitialized context

Mikolaj Wasiak mikolaj.wasiak at intel.com
Wed Jan 29 08:45:21 UTC 2025


Hi Krzysztof

> +	if (!ppgtt->vm.allocate_va_range) {
> +	        i915_vm_put(&ppgtt->vm);
> +	        return 0;
> +	}

I don't know if it feels more in line with kernel style, but consider
changing it to a label before second `i915_vm_put` at end of function
plus goto instead of creating new cleanup section.

Otherwise looks alright.
Reviewed-by: Mikolaj Wasiak <mikolaj.wasiak at intel.com>

Mikolaj


More information about the Intel-gfx mailing list