[PATCH v14 4/9] ref_tracker: add a static classname string to each ref_tracker_dir
Krzysztof Karas
krzysztof.karas at intel.com
Wed Jun 11 10:32:02 UTC 2025
Hi Jeff,
> A later patch in the series will be adding debugfs files for each
> ref_tracker that get created in ref_tracker_dir_init(). The format will
> be "class@%px". The current "name" string can vary between
> ref_tracker_dir objects of the same type, so it's not suitable for this
> purpose.
>
> Add a new "class" string to the ref_tracker dir that describes the
> the type of object (sans any individual info for that object).
>
> Also, in the i915 driver, gate the creation of debugfs files on whether
> the dentry pointer is still set to NULL. CI has shown that the
> ref_tracker_dir can be initialized more than once.
>
> Signed-off-by: Jeff Layton <jlayton at kernel.org>
> ---
Looks good:
Reviewed-by: Krzysztof Karas <krzysztof.karas at intel.com>
A side note:
I was wondering if we could improve naming a bit, but I think it
is not worth the effort. Names like "dptun" instead of
"dp_tunnel" and including "wakeref" only in
__intel_wakeref_init() but not in init_intel_runtime_pm_wakeref()
in "intel_runtime_pm" string stand out, but it is quite clear
what these names mean, so I added my r-b.
Best Regards,
Krzysztof
More information about the Intel-gfx
mailing list