[RESEND 3/5] drm/i915/plane: make intel_plane_atomic_check() static and rename

Gustavo Sousa gustavo.sousa at intel.com
Thu Jun 12 12:14:49 UTC 2025


Quoting Jani Nikula (2025-06-12 08:37:09-03:00)
>intel_plane_atomic_check() isn't used outside of intel_plane.c. Make it
>static. While at it, rename to vacate the name for subsequent changes.
>
>Signed-off-by: Jani Nikula <jani.nikula at intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

>---
> drivers/gpu/drm/i915/display/intel_plane.c | 6 +++---
> drivers/gpu/drm/i915/display/intel_plane.h | 2 --
> 2 files changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_plane.c b/drivers/gpu/drm/i915/display/intel_plane.c
>index f68432d28d36..fbbe957d3f04 100644
>--- a/drivers/gpu/drm/i915/display/intel_plane.c
>+++ b/drivers/gpu/drm/i915/display/intel_plane.c
>@@ -734,8 +734,8 @@ intel_crtc_get_plane(struct intel_crtc *crtc, enum plane_id plane_id)
>         return NULL;
> }
> 
>-int intel_plane_atomic_check(struct intel_atomic_state *state,
>-                             struct intel_plane *plane)
>+static int plane_atomic_check(struct intel_atomic_state *state,
>+                              struct intel_plane *plane)
> {
>         struct intel_display *display = to_intel_display(state);
>         struct intel_plane_state *new_plane_state =
>@@ -1542,7 +1542,7 @@ int intel_atomic_check_planes(struct intel_atomic_state *state)
>                 return ret;
> 
>         for_each_new_intel_plane_in_state(state, plane, plane_state, i) {
>-                ret = intel_plane_atomic_check(state, plane);
>+                ret = plane_atomic_check(state, plane);
>                 if (ret) {
>                         drm_dbg_atomic(display->drm,
>                                        "[PLANE:%d:%s] atomic driver check failed\n",
>diff --git a/drivers/gpu/drm/i915/display/intel_plane.h b/drivers/gpu/drm/i915/display/intel_plane.h
>index 10a94b9a135c..4d69a868265c 100644
>--- a/drivers/gpu/drm/i915/display/intel_plane.h
>+++ b/drivers/gpu/drm/i915/display/intel_plane.h
>@@ -69,8 +69,6 @@ int intel_plane_atomic_check_with_state(const struct intel_crtc_state *old_crtc_
>                                         struct intel_crtc_state *crtc_state,
>                                         const struct intel_plane_state *old_plane_state,
>                                         struct intel_plane_state *intel_state);
>-int intel_plane_atomic_check(struct intel_atomic_state *state,
>-                             struct intel_plane *plane);
> int intel_plane_calc_min_cdclk(struct intel_atomic_state *state,
>                                struct intel_plane *plane,
>                                bool *need_cdclk_calc);
>-- 
>2.39.5
>


More information about the Intel-gfx mailing list