[PATCH v2 01/22] drm/i915/gvt: Rework shadow graphic memory management code

Du, Changbin changbin.du at intel.com
Fri Dec 22 03:31:00 UTC 2017


On Fri, Dec 22, 2017 at 11:05:29AM +0800, Zhenyu Wang wrote:
> On 2017.12.20 17:39:06 +0800, changbin.du at intel.com wrote:
> > From: Changbin Du <changbin.du at intel.com>
> > 
> > This is a big one and the GVT shadow graphic memory management code is
> > heavily refined. The new code is more straightforward with less code.
> > 
> > The struct intel_vgpu_mm is restructured to be clearly defined, use
> > accurate names and some of the original fields are removed which are
> > really redundant.
> > 
> > Now we only manage ppgtt mm object with mm->ppgtt_mm.lru_list. No need
> > to mix ppgtt and ggtt together, since one vGPU only has one ggtt object.
> > 
> > The reference count of mm obj is unified and define clear interface.
> > 
> > Some GEM assertions are added to verify our code. The can prevent bugs
> > in developing stage.
> > 
> > And also there are some other refines, but they're hard to split because
> > I need ensure each patch is compileable at least.
> >
> 
> It's difficult to review whole this in one and I was lost in half way..
> looks too many different changes mixed together, better to do more split
> for easy review.
>
Zhenyu, I'd like to, but it is really hard because the datastruture is
restructured then split them will create compiling failure for single patch.
A basic rule is very single patch is compilable.

> -- 
> Open Source Technology Center, Intel ltd.
> 
> $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827



> _______________________________________________
> intel-gvt-dev mailing list
> intel-gvt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gvt-dev


-- 
Thanks,
Changbin Du


More information about the intel-gvt-dev mailing list