[Intel-xe] [RESEND 1/5] drm/i915/uncore: add intel_uncore_regs() helper

Jani Nikula jani.nikula at intel.com
Tue Jul 11 08:15:22 UTC 2023


On Mon, 10 Jul 2023, Andi Shyti <andi.shyti at linux.intel.com> wrote:
> Hi Jani,
>
> On Fri, Jun 30, 2023 at 02:50:15PM +0300, Jani Nikula wrote:
>> Add a helper for accessing uncore->regs instead of doing it
>> directly. This will help display code reuse with the xe driver.
>
> I asked you in a previous mail if you had tried
> intel_uncore_{read,write}_fw() helpers instead of the simple
> intel_uncore_{read,write}.

Yes, sorry. I decided this was a more generally useful approach,
abstracting the uncore->regs access everywhere.

This does not block a further cleanup.

BR,
Jani.


>
> Thanks,
> Andi

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-xe mailing list