[Intel-xe] [RESEND 1/5] drm/i915/uncore: add intel_uncore_regs() helper

Andi Shyti andi.shyti at linux.intel.com
Tue Jul 11 10:32:24 UTC 2023


Hi Jani,

On Tue, Jul 11, 2023 at 11:15:22AM +0300, Jani Nikula wrote:
> On Mon, 10 Jul 2023, Andi Shyti <andi.shyti at linux.intel.com> wrote:
> > Hi Jani,
> >
> > On Fri, Jun 30, 2023 at 02:50:15PM +0300, Jani Nikula wrote:
> >> Add a helper for accessing uncore->regs instead of doing it
> >> directly. This will help display code reuse with the xe driver.
> >
> > I asked you in a previous mail if you had tried
> > intel_uncore_{read,write}_fw() helpers instead of the simple
> > intel_uncore_{read,write}.
> 
> Yes, sorry. I decided this was a more generally useful approach,
> abstracting the uncore->regs access everywhere.
> 
> This does not block a further cleanup.

OK, either way, I'm fine with it:

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

Thank you!
Andi


More information about the Intel-xe mailing list