[Intel-xe] [PATCH v2 1/2] drm/xe/execlist: Remove leftover printk messages

[Lucas De Marchi]

On Wed, Jul 19, 2023 at 11:28:43AM -0400, Rodrigo Vivi wrote:
>On Wed, Jul 19, 2023 at 01:51:07PM +0000, Francois Dugast wrote:
>> Those look like leftover debug and are not even being used. If they were
>> real debug/info, they should be using the drm helpers.
>>
>> Signed-off-by: Francois Dugast <francois.dugast at intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_execlist.c | 8 --------
>>  1 file changed, 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
>> index 46293c9bb6a8..3aec37985f32 100644
>> --- a/drivers/gpu/drm/xe/xe_execlist.c
>> +++ b/drivers/gpu/drm/xe/xe_execlist.c
>> @@ -47,8 +47,6 @@ static void __start_lrc(struct xe_hw_engine *hwe, struct xe_lrc *lrc,
>>  	struct xe_device *xe = gt_to_xe(gt);
>>  	u64 lrc_desc;
>>
>> -	printk(KERN_INFO "__start_lrc(%s, 0x%p, %u)\n", hwe->name, lrc, ctx_id);
>> -
>>  	lrc_desc = xe_lrc_descriptor(lrc);
>>
>>  	if (GRAPHICS_VERx100(xe) >= 1250) {
>> @@ -125,9 +123,6 @@ static void __xe_execlist_port_idle(struct xe_execlist_port *port)
>>  	if (!port->running_exl)
>>  		return;
>>
>> -	printk(KERN_INFO "__xe_execlist_port_idle(%d:%d)\n", port->hwe->class,
>> -	       port->hwe->instance);
>> -
>>  	xe_lrc_write_ring(&port->hwe->kernel_lrc, noop, sizeof(noop));
>>  	__start_lrc(port->hwe, &port->hwe->kernel_lrc, 0);
>>  	port->running_exl = NULL;
>> @@ -176,9 +171,6 @@ static u64 read_execlist_status(struct xe_hw_engine *hwe)
>>  	lo = xe_mmio_read32(gt, RING_EXECLIST_STATUS_LO(hwe->mmio_base));
>>  	hi = xe_mmio_read32(gt, RING_EXECLIST_STATUS_HI(hwe->mmio_base));
>>
>> -	printk(KERN_INFO "EXECLIST_STATUS %d:%d = 0x%08x %08x\n", hwe->class,
>> -	       hwe->instance, hi, lo);
>
>This one is indeed annoying when it happens, so we need to get rid of,
>but I believe we need to have at least a big drm_info somewhere to let us
>know that execlist is in place. Probably at execlist_engine_init ?!

at this point, probably a warning at execlist_engine_init() and
independent of this patch.


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>


Lucas De Marchi

>
>> -
>>  	return lo | (u64)hi << 32;
>>  }
>>
>> --
>> 2.34.1
>>