[Intel-xe] [PATCH] drm/xe/vm: fix double list add

[Maarten Lankhorst]

On 2023-06-01 16:16, Matthew Auld wrote:
> Hi,
>
> On 01/06/2023 14:19, Maarten Lankhorst wrote:
>> Hey,
>>
>> I guess that should make the ignore argument pointless?
>
> IIUC we have something like:
>
> vma = create_vma(vm, bo, ...) -> list_add(..., bo->vmas)
> ....
> vm_insert_extobj(vm, vma)
>
> Here we need the "ignore", otherwise bo_has_vm_references() in vm_insert_extobj() might incorrectly think the vma we just added to bo->vmas counts as a reference, and then the vma never becomes tracked as external. Or am I missing something here?

Hey,


I guess it could be done before adding it to list of vma's instead. However that's  good enough reason for me to keep ignore. :-)

Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>