[Intel-xe] [PATCH 0/3] drm/xe: Add sysfs entry to report per gt memory size

[Upadhyay, Tejas]

> -----Original Message-----
> From: Iddamsetty, Aravind <aravind.iddamsetty at intel.com>
> Sent: Tuesday, May 30, 2023 12:22 PM
> To: Upadhyay, Tejas <tejas.upadhyay at intel.com>; intel-
> xe at lists.freedesktop.org; Roper, Matthew D <matthew.d.roper at intel.com>
> Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Dixit, Ashutosh
> <ashutosh.dixit at intel.com>
> Subject: RE: [PATCH 0/3] drm/xe: Add sysfs entry to report per gt memory
> size
> 
> 
> 
> > -----Original Message-----
> > From: Iddamsetty, Aravind
> > Sent: Monday, May 29, 2023 2:15 PM
> > To: Upadhyay, Tejas <tejas.upadhyay at intel.com>; intel-
> > xe at lists.freedesktop.org
> > Cc: Vivi, Rodrigo <rodrigo.vivi at intel.com>; Dixit, Ashutosh
> > <ashutosh.dixit at intel.com>; Roper, Matthew D
> > <matthew.d.roper at intel.com>
> > Subject: RE: [PATCH 0/3] drm/xe: Add sysfs entry to report per gt
> > memory size
> >
> >
> >
> > > -----Original Message-----
> > > From: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> > > Sent: Monday, May 29, 2023 2:10 PM
> > > To: intel-xe at lists.freedesktop.org
> > > Cc: Iddamsetty, Aravind <aravind.iddamsetty at intel.com>; Vivi,
> > > Rodrigo <rodrigo.vivi at intel.com>; Dixit, Ashutosh
> > > <ashutosh.dixit at intel.com>; Roper, Matthew D
> > > <matthew.d.roper at intel.com>
> > > Subject: RE: [PATCH 0/3] drm/xe: Add sysfs entry to report per gt
> > > memory size
> > >
> > > Initiating discussion on sysfs path for this inline below :
> > >
> > > > -----Original Message-----
> > > > From: Upadhyay, Tejas <tejas.upadhyay at intel.com>
> > > > Sent: Thursday, May 4, 2023 4:50 PM
> > > > To: intel-xe at lists.freedesktop.org
> > > > Cc: Upadhyay, Tejas <tejas.upadhyay at intel.com>; Iddamsetty,
> > > > Aravind <aravind.iddamsetty at intel.com>
> > > > Subject: [PATCH 0/3] drm/xe: Add sysfs entry to report per gt
> > > > memory size
> > > >
> > > > Add sysfs entry to read per gt physical memory in total including
> > > > stolen memory.
> > > >
> > > > The sysfs entry added can be read using:
> > > > cat /sys/class/drm/card1/gt/gt0/addr_range
> > > > cat /sys/class/drm/card1/gt/gt1/addr_range
> > >
> > > We already have gt#num directory created under device folder, should
> > > we create addr_range under that only. I think that would be straight
> > > forward to start with.  For example,
> > >
> > >
> /devices/pci0000:a7/0000:a7:01.0/0000:a8:00.0/0000:a9:01.0/0000:aa:00.
> > > 0/
> > > drm/card1/gt0/addr_range
> > >
> > > Initiating discussion there to conclude on path on this sysfs entry
> > > as well as scheduler interface entries as well as under "engine"
> > > folder under
> > card1.
> 
> Also, now with Matt's " Separate GT and tile" series addr_range is associated
> to a tile rather than gt.  We might have to introduce "tile" in sysfs

Hi @Roper, Matthew D, @Vivi, Rodrigo,

Should we expose tile0/1->addr_range to user, with sysfs like device/tile0/gt0, device/tile1/gt1? Looking for inputs here to move forward with second version of this patch.

Thanks,
Tejas
> 
> Thanks,
> Aravind.
> 
> >
> > Scheduler/engine entries are not related to this feature let's discuss
> > them separately.
> >
> > Thanks,
> > Aravind.
> >
> > >
> > > Please provide your inputs.
> > >
> > > Thanks,
> > > Tejas
> > > >
> > > > As it involves drm_class, it required movement in xe_device init
> > > > flow, patch for same is part of this series.
> > > >
> > > > Actual physical memory per GT was dependent on infra patch from
> > > > Ruhl, Michael J, so I have added it as part of this series to pass
> > > > through pre-
> > > merge.
> > > > Patchwork: https://patchwork.freedesktop.org/series/117126/#rev3
> > > >
> > > > Cc: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
> > > > Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> > > >
> > > > Tejas Upadhyay (3):
> > > >   drm/xe: Rework multi tile device memory initialization
> > > >   drm/xe: Register drm device prior to gt init
> > > >   drm/xe: Add sysfs entry to report per gt memory size
> > > >
> > > >  drivers/gpu/drm/xe/regs/xe_gt_regs.h   |   2 +-
> > > >  drivers/gpu/drm/xe/xe_bo.c             |   8 +-
> > > >  drivers/gpu/drm/xe/xe_bo.h             |   2 +-
> > > >  drivers/gpu/drm/xe/xe_device.c         |   8 +-
> > > >  drivers/gpu/drm/xe/xe_device_types.h   |  20 +-
> > > >  drivers/gpu/drm/xe/xe_gt_sysfs.c       |  74 ++++++-
> > > >  drivers/gpu/drm/xe/xe_gt_sysfs.h       |   1 -
> > > >  drivers/gpu/drm/xe/xe_gt_types.h       |  21 +-
> > > >  drivers/gpu/drm/xe/xe_migrate.c        |   6 +-
> > > >  drivers/gpu/drm/xe/xe_mmio.c           | 279 ++++++++++++++-----------
> > > >  drivers/gpu/drm/xe/xe_mmio.h           |   4 +-
> > > >  drivers/gpu/drm/xe/xe_ttm_stolen_mgr.c |  30 +--
> > > >  12 files changed, 291 insertions(+), 164 deletions(-)
> > > >
> > > > --
> > > > 2.25.1