[Intel-xe] [PATCH] drm/xe: Prevent flooding the kernel log with XE_IOCTL_ERR

Jani Nikula jani.nikula at linux.intel.com
Fri Jun 2 09:29:53 UTC 2023


On Thu, 01 Jun 2023, Matt Roper <matthew.d.roper at intel.com> wrote:
> One concern with "_ASSERT" is that people may incorrectly assume that
> it's something that only gets compiled into debug builds.  But with a
> different name like "_CHECK" or "_EXPECT" your proposal below looks okay
> to me.

On a related note, the reverse of this is one of the biggest issues I
have with GEM_BUG_ON() in i915. There's no hint that it's only for debug
configs. Having ASSERT in the name would go a long way in clarifying it.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-xe mailing list