[Intel-xe] [PATCH 2/3] drm/xe: Initialize MOCS earlier

Matthew Brost matthew.brost at intel.com
Mon Jun 5 17:09:06 UTC 2023


On Fri, Jun 02, 2023 at 04:52:09PM -0700, Matt Roper wrote:
> xe_mocs_init_early doesn't touch the hardware, it just sets up internal
> software state.  There's no need to perform this step in the "forcewake
> held" region.  Moving the init earlier will also make the uc_index
> values available earlier which will be important for an upcoming GuC
> init patch.
> 
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Matthew Brost <matthew.brost at intel.com>

> ---
>  drivers/gpu/drm/xe/xe_gt.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt.c b/drivers/gpu/drm/xe/xe_gt.c
> index 335148f1cd39..3799e663bad3 100644
> --- a/drivers/gpu/drm/xe/xe_gt.c
> +++ b/drivers/gpu/drm/xe/xe_gt.c
> @@ -315,8 +315,6 @@ static int gt_fw_domain_init(struct xe_gt *gt)
>  	/* Rerun MCR init as we now have hw engine list */
>  	xe_gt_mcr_init(gt);
>  
> -	xe_mocs_init_early(gt);
> -
>  	err = xe_hw_engines_init_early(gt);
>  	if (err)
>  		goto err_force_wake;
> @@ -429,6 +427,8 @@ int xe_gt_init(struct xe_gt *gt)
>  	if (err)
>  		return err;
>  
> +	xe_mocs_init_early(gt);
> +
>  	xe_gt_sysfs_init(gt);
>  
>  	err = gt_fw_domain_init(gt);
> -- 
> 2.40.1
> 


More information about the Intel-xe mailing list