[Intel-xe] ✗ CI.checkpatch: warning for drm/xe: Add sysfs entry for tile and relate it to GTs (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Jun 7 10:08:00 UTC 2023


== Series Details ==

Series: drm/xe: Add sysfs entry for tile and relate it to GTs (rev2)
URL   : https://patchwork.freedesktop.org/series/118927/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit edc4e6274b1ac969d6282e0c4859c3a7916b9df9
Author: Tejas Upadhyay <tejas.upadhyay at intel.com>
Date:   Wed Jun 7 15:41:03 2023 +0530

    drm/xe: Add sysfs entry to report per tile memory size
    
    Add sysfs entry to read per tile physical memory
    including stolen memory.
    
    V2:
      - Use DEVICE_ATTR_RO - Aravind
      - Dont put kobj on sysfs_file_create fail - Himal
      - Skip addr_range sysfs create for non dgfx - Himal
    
    Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
+ /mt/dim checkpatch 0f657f7b7f8886953ec1d946965a90fd286a6591 drm-intel
643b1e753 drm/xe: Add sysfs entry for tile
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:76: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#76: 
new file mode 100644

-:100: WARNING:CONST_STRUCT: struct kobj_type should normally be const
#100: FILE: drivers/gpu/drm/xe/xe_tile_sysfs.c:20:
+static struct kobj_type xe_tile_sysfs_kobj_type = {

-:121: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#121: FILE: drivers/gpu/drm/xe/xe_tile_sysfs.c:41:
+	if (!kg) {
+		drm_warn(&xe->drm, "%s failed, err: %d\n", __func__, -ENOMEM);

total: 0 errors, 3 warnings, 0 checks, 150 lines checked
2e486c0a6 drm/xe: Add GTs under respective tile sysfs
edc4e6274 drm/xe: Add sysfs entry to report per tile memory size




More information about the Intel-xe mailing list