[Intel-xe] [PATCH v2 5/5] drm/xe: Fix some formatting issues in uAPI

[Francois Dugast]

On Tue, Jun 06, 2023 at 10:26:39PM -0700, Lucas De Marchi wrote:
> On Wed, May 31, 2023 at 03:23:38PM +0000, Francois Dugast wrote:
> > Reported-by: Oded Gabbay <ogabbay at kernel.org>
> > Link: https://lists.freedesktop.org/archives/intel-xe/2023-May/004704.html
> > Signed-off-by: Francois Dugast <francois.dugast at intel.com>
> 
> no commit should be without commit message... need to spell out what
> "some formatting issues" are, like the spacing, alignment, and repeated
> words. With that and a rebase,
> 
> 	Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Thanks, will do.

> 
> Not sure about the "Link:" usage here as it seems to be unique to these
> patches.

It seems it is used already, even to link to freedesktop archives:

	git log --after=2022-01-01 | grep "Link: https://lists.freedesktop.org"

The intention is to link patches with the review batches but I am fine
dropping it and keeping track in a separate list.

Francois

> 
> Lucas De Marchi
> 
> > ---
> > include/uapi/drm/xe_drm.h | 24 ++++++++++++------------
> > 1 file changed, 12 insertions(+), 12 deletions(-)
> > 
> > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> > index e29399de148c..667cd60db3d5 100644
> > --- a/include/uapi/drm/xe_drm.h
> > +++ b/include/uapi/drm/xe_drm.h
> > @@ -105,16 +105,16 @@ struct xe_user_extension {
> > #define DRM_IOCTL_XE_GEM_CREATE			DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_GEM_CREATE, struct drm_xe_gem_create)
> > #define DRM_IOCTL_XE_GEM_MMAP_OFFSET		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_GEM_MMAP_OFFSET, struct drm_xe_gem_mmap_offset)
> > #define DRM_IOCTL_XE_VM_CREATE			DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_VM_CREATE, struct drm_xe_vm_create)
> > -#define DRM_IOCTL_XE_VM_DESTROY			DRM_IOW( DRM_COMMAND_BASE + DRM_XE_VM_DESTROY, struct drm_xe_vm_destroy)
> > -#define DRM_IOCTL_XE_VM_BIND			DRM_IOW( DRM_COMMAND_BASE + DRM_XE_VM_BIND, struct drm_xe_vm_bind)
> > +#define DRM_IOCTL_XE_VM_DESTROY			 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_VM_DESTROY, struct drm_xe_vm_destroy)
> > +#define DRM_IOCTL_XE_VM_BIND			 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_VM_BIND, struct drm_xe_vm_bind)
> > #define DRM_IOCTL_XE_ENGINE_CREATE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_ENGINE_CREATE, struct drm_xe_engine_create)
> > #define DRM_IOCTL_XE_ENGINE_GET_PROPERTY	DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_ENGINE_GET_PROPERTY, struct drm_xe_engine_get_property)
> > -#define DRM_IOCTL_XE_ENGINE_DESTROY		DRM_IOW( DRM_COMMAND_BASE + DRM_XE_ENGINE_DESTROY, struct drm_xe_engine_destroy)
> > -#define DRM_IOCTL_XE_EXEC			DRM_IOW( DRM_COMMAND_BASE + DRM_XE_EXEC, struct drm_xe_exec)
> > +#define DRM_IOCTL_XE_ENGINE_DESTROY		 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_ENGINE_DESTROY, struct drm_xe_engine_destroy)
> > +#define DRM_IOCTL_XE_EXEC			 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_EXEC, struct drm_xe_exec)
> > #define DRM_IOCTL_XE_MMIO			DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_MMIO, struct drm_xe_mmio)
> > -#define DRM_IOCTL_XE_ENGINE_SET_PROPERTY	DRM_IOW( DRM_COMMAND_BASE + DRM_XE_ENGINE_SET_PROPERTY, struct drm_xe_engine_set_property)
> > +#define DRM_IOCTL_XE_ENGINE_SET_PROPERTY	 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_ENGINE_SET_PROPERTY, struct drm_xe_engine_set_property)
> > #define DRM_IOCTL_XE_WAIT_USER_FENCE		DRM_IOWR(DRM_COMMAND_BASE + DRM_XE_WAIT_USER_FENCE, struct drm_xe_wait_user_fence)
> > -#define DRM_IOCTL_XE_VM_MADVISE			DRM_IOW( DRM_COMMAND_BASE + DRM_XE_VM_MADVISE, struct drm_xe_vm_madvise)
> > +#define DRM_IOCTL_XE_VM_MADVISE			 DRM_IOW(DRM_COMMAND_BASE + DRM_XE_VM_MADVISE, struct drm_xe_vm_madvise)
> > 
> > #define XE_MEM_REGION_CLASS_SYSMEM	0
> > #define XE_MEM_REGION_CLASS_VRAM	1
> > @@ -154,7 +154,7 @@ struct drm_xe_query_config {
> > #define XE_QUERY_CONFIG_GT_COUNT		4
> > #define XE_QUERY_CONFIG_MEM_REGION_COUNT	5
> > #define XE_QUERY_CONFIG_MAX_ENGINE_PRIORITY	6
> > -#define XE_QUERY_CONFIG_NUM_PARAM		XE_QUERY_CONFIG_MAX_ENGINE_PRIORITY + 1
> > +#define XE_QUERY_CONFIG_NUM_PARAM		(XE_QUERY_CONFIG_MAX_ENGINE_PRIORITY + 1)
> > 	/** @info: array containing the config info below  */
> > 	__u64 info[];
> > };
> > @@ -411,8 +411,8 @@ struct drm_xe_vm_bind_op {
> > 	 * If this flag is clear and the IOCTL doesn't return an error, in
> > 	 * practice the bind op is good and will complete.
> > 	 *
> > -	 * If this flag is set and doesn't return return an error, the bind op
> > -	 * can still fail and recovery is needed. If configured, the bind op that
> > +	 * If this flag is set and doesn't return an error, the bind op can
> > +	 * still fail and recovery is needed. If configured, the bind op that
> > 	 * caused the error will be captured in drm_xe_vm_bind_op_error_capture.
> > 	 * Once the user sees the error (via a ufence +
> > 	 * XE_VM_PROPERTY_BIND_OP_ERROR_CAPTURE_ADDRESS), it should free memory
> > @@ -651,9 +651,9 @@ struct drm_xe_exec {
> > 	__u64 syncs;
> > 
> > 	/**
> > -	  * @address: address of batch buffer if num_batch_buffer == 1 or an
> > -	  * array of batch buffer addresses
> > -	  */
> > +	 * @address: address of batch buffer if num_batch_buffer == 1 or an
> > +	 * array of batch buffer addresses
> > +	 */
> > 	__u64 address;
> > 
> > 	/**
> > -- 
> > 2.34.1
> >