[Intel-xe] [PATCH V3 2/3] drm/xe: Add GTs under respective tile sysfs

[Iddamsetty, Aravind]

On 08-06-2023 13:15, Tejas Upadhyay wrote:
> With the separation of xe_tile and xe_gt, We now consider
> a PCI device (xe_device) to contain one or more tiles (struct xe_tile).
> Each tile will contain one or two GTs (struct xe_gt).

better reword to one or more, as we do not know in future we might have
more than 2.

> So lets align sysfs paths accordingly.
> 
> TODO: Currently we have gt0 under tile0 and gt1 under tile1
> on multi-tile. This GT indexing still under discussion, when
> it is concluded we need to revisit this change.
> 
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_gt_sysfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_gt_sysfs.c b/drivers/gpu/drm/xe/xe_gt_sysfs.c
> index c01cc689058c..13570987a756 100644
> --- a/drivers/gpu/drm/xe/xe_gt_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_gt_sysfs.c
> @@ -31,7 +31,7 @@ static void gt_sysfs_fini(struct drm_device *drm, void *arg)
>  
>  int xe_gt_sysfs_init(struct xe_gt *gt)
>  {
> -	struct device *dev = gt_to_xe(gt)->drm.dev;
> +	struct xe_tile *tile = gt_to_tile(gt);
>  	struct kobj_gt *kg;
>  	int err;
>  
> @@ -42,7 +42,7 @@ int xe_gt_sysfs_init(struct xe_gt *gt)
>  	kobject_init(&kg->base, &xe_gt_sysfs_kobj_type);
>  	kg->gt = gt;
>  
> -	err = kobject_add(&kg->base, &dev->kobj, "gt%d", gt->info.id);
> +	err = kobject_add(&kg->base, tile->sysfs, "gt%d", gt->info.id);
>  	if (err) {
>  		kobject_put(&kg->base);
>  		return err;

Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty at intel.com>

Thanks,
Aravind.