[Intel-xe] ✗ CI.checkpatch: warning for GuC doorbells for submission

[Patchwork]

== Series Details ==

Series: GuC doorbells for submission
URL   : https://patchwork.freedesktop.org/series/119096/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 5218db4afa59f8f4e32963f86671b9b49281cec4
Author: Matthew Brost <matthew.brost at intel.com>
Date:   Thu Jun 8 13:08:57 2023 -0700

    drm/xe/guc: Print doorbell ID in GuC engine debugfs / error capture
    
    This information is helpful so print it.
    
    Signed-off-by: Matthew Brost <matthew.brost at intel.com>
+ /mt/dim checkpatch c075cadc4c6d0238556545baab98a63368908404 drm-intel
e07cdc0ac drm/xe/guc: Read HXG fields from DW1 of G2H response
8aa9c4dad drm/xe/guc: Return the lower part of blocking H2G message
89f1d5ae9 drm/xe/guc: Use doorbells for submission if possible
-:114: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe' - possible side-effects?
#114: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:40:
+#define HAS_GUC_MMIO_DB(xe) (IS_DGFX(xe) || GRAPHICS_VERx100(xe) >= 1250)

-:115: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'xe' - possible side-effects?
#115: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:41:
+#define HAS_GUC_DIST_DB(xe) \
+	(GRAPHICS_VERx100(xe) >= 1200 && !HAS_GUC_MMIO_DB(xe))

-:255: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'e_' - possible side-effects?
#255: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:351:
+#define doorbell_read(guc_, e_, field_) ({			\
+	struct iosys_map _vmap = (e_)->guc->doorbell_bo->vmap;	\
+	iosys_map_incr(&_vmap, (e_)->guc->doorbell_offset);	\
+	xe_map_rd_field(guc_to_xe((guc_)), &_vmap, 0,		\
+				  struct guc_doorbell_info, field_); \
+	})

-:261: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'e_' - possible side-effects?
#261: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:357:
+#define doorbell_write(guc_, e_, field_, val_) ({		\
+	struct iosys_map _vmap = (e_)->guc->doorbell_bo->vmap;	\
+	iosys_map_incr(&_vmap, (e_)->guc->doorbell_offset);	\
+	xe_map_wr_field(guc_to_xe((guc_)), &_vmap, 0,		\
+				  struct guc_doorbell_info, field_, val_); \
+	})

-:322: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#322: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:418:
+	XE_BUG_ON(!has_doorbell(e));

-:342: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#342: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:438:
+	XE_BUG_ON(!has_doorbell(e));

-:509: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#509: FILE: drivers/gpu/drm/xe/xe_guc_submit.c:1502:
+	XE_BUG_ON(engine_registered(e) && !has_doorbell(e));

total: 0 errors, 3 warnings, 4 checks, 492 lines checked
5218db4af drm/xe/guc: Print doorbell ID in GuC engine debugfs / error capture