[Intel-xe] [PATCH 3/5] drm/xe/guc: Normalize error messages with %#x
Lucas De Marchi
lucas.demarchi at intel.com
Sun Jun 11 22:24:45 UTC 2023
One of the messages was printed without 0x prefix, so it was not clear
if it was decimal or hex: make sure to add the prefix by using %#x.
While at it, normalize the other messages in the same function to follow
the same pattern.
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
---
drivers/gpu/drm/xe/xe_guc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_guc.c b/drivers/gpu/drm/xe/xe_guc.c
index e51d8fb4a354..43f862aaacbe 100644
--- a/drivers/gpu/drm/xe/xe_guc.c
+++ b/drivers/gpu/drm/xe/xe_guc.c
@@ -647,7 +647,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
GUC_HXG_MSG_0_ORIGIN, 50000, &reply, false);
if (ret) {
timeout:
- drm_err(&xe->drm, "mmio request 0x%08x: no reply 0x%08x\n",
+ drm_err(&xe->drm, "mmio request %#x: no reply %#x\n",
request[0], reply);
return ret;
}
@@ -673,7 +673,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
GUC_HXG_TYPE_NO_RESPONSE_RETRY) {
u32 reason = FIELD_GET(GUC_HXG_RETRY_MSG_0_REASON, header);
- drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %u\n",
+ drm_dbg(&xe->drm, "mmio request %#x: retrying, reason %#x\n",
request[0], reason);
goto retry;
}
@@ -683,7 +683,7 @@ int xe_guc_mmio_send_recv(struct xe_guc *guc, const u32 *request,
u32 hint = FIELD_GET(GUC_HXG_FAILURE_MSG_0_HINT, header);
u32 error = FIELD_GET(GUC_HXG_FAILURE_MSG_0_ERROR, header);
- drm_err(&xe->drm, "mmio request %#x: failure %x/%u\n",
+ drm_err(&xe->drm, "mmio request %#x: failure %#x/%#x\n",
request[0], error, hint);
return -ENXIO;
}
--
2.40.1
More information about the Intel-xe
mailing list