[Intel-xe] ✗ CI.checkpatch: warning for xe_device_mem_access fixes and related bits

[Patchwork]

== Series Details ==

Series: xe_device_mem_access fixes and related bits
URL   : https://patchwork.freedesktop.org/series/119213/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 7e9e80f23cc17aeea83239561efcf4a905678565
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Jun 12 18:12:25 2023 +0100

    drm/xe: add lockdep annotation for xe_device_mem_access_get()
    
    The atomics here might hide potential issues, so add a dummy lock with
    the idea that xe_pm_runtime_resume() is eventually going to be called
    when we are holding it. This only need to happen once and then lockdep
    can validate all callers and their locks.
    
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
    Cc: Thomas Hellström <thomas.hellstrom at linux.intel.com>
+ /mt/dim checkpatch f041ab3bfcd9d0643b5cadb8916f67e8e234356c drm-intel
cfd55827f drm/xe: fix xe_device_mem_access_get() races
-:55: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Closes:', use 'Link:' instead
#55: 
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/258

-:74: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "xe_pm_read_callback_task"
#74: FILE: drivers/gpu/drm/xe/xe_device.c:416:
+	if (xe_pm_read_callback_task(xe) != NULL)

-:225: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!xe_pm_read_callback_task"
#225: FILE: drivers/gpu/drm/xe/xe_guc_ct.c:1109:
+	if (!ongoing && xe_pm_read_callback_task(ct_to_xe(ct)) == NULL)

total: 0 errors, 1 warnings, 2 checks, 287 lines checked
40cd95300 drm/xe/vm: tidy up xe_runtime_pm usage
-:13: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Link: with a URL to the report
#13: 
Reported-by: Oded Gabbay <ogabbay at kernel.org>
Signed-off-by: Matthew Auld <matthew.auld at intel.com>

total: 0 errors, 1 warnings, 0 checks, 30 lines checked
6b0636e45 drm/xe/debugfs: grab mem_access around forcewake
-:11: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Closes:', use 'Link:' instead
#11: 
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/279

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
bdc743007 drm/xe/mmio: grab mem_access in xe_mmio_ioctl
ca90c955e drm/xe: ensure correct access_put ordering
1d39a990c drm/xe/pci: wrap probe with mem_access
2b309e1ba drm/xe/display: use mem_access underneath
aca604862 drm/xe/mmio: enforce xe_device_assert_mem_access
c887f2b2e drm/xe: drop xe_device_mem_access_get() from guc_ct_send
969df2764 drm/xe/ggtt: prime ggtt->lock against FS_RECLAIM
d72aab679 drm/xe: drop xe_device_mem_access_get() from invalidation_vma
7e9e80f23 drm/xe: add lockdep annotation for xe_device_mem_access_get()