[Intel-xe] [PATCH v11 04/12] drm/xe/mmio: grab mem_access in xe_mmio_ioctl

[Matthew Brost]

On Mon, Jun 12, 2023 at 06:12:17PM +0100, Matthew Auld wrote:
> Any kind of device memory access should first ensure the device is not
> suspended, mmio included.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_mmio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
> index f7a7f996b37f..cc5ccbef85a4 100644
> --- a/drivers/gpu/drm/xe/xe_mmio.c
> +++ b/drivers/gpu/drm/xe/xe_mmio.c
> @@ -476,6 +476,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data,
>  	 */
>  	reg = XE_REG(args->addr);
>  
> +	xe_device_mem_access_get(xe);

What about moving xe_device_mem_access_get/put to xe_force_wake_get/put?
Just an idea, but this patch LGTM so I'll leave it up to you if you want
to keep it as is.

With that:
Reviewed-by: Matthew Brost <matthew.brost at intel.com>

>  	xe_force_wake_get(gt_to_fw(gt), XE_FORCEWAKE_ALL);
>  
>  	if (args->flags & DRM_XE_MMIO_WRITE) {
> @@ -519,6 +520,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data,
>  
>  exit:
>  	xe_force_wake_put(gt_to_fw(gt), XE_FORCEWAKE_ALL);
> +	xe_device_mem_access_put(xe);
>  
>  	return ret;
>  }
> -- 
> 2.40.1
>