[Intel-xe] [PATCH] drm/Xe: Use EOPNOTSUPP instead of ENOTSUPP
janga.rahul.kumar at intel.com
janga.rahul.kumar at intel.com
Tue Jun 13 09:37:40 UTC 2023
From: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
ENOTSUPP is not a standard Unix error should use
EOPNOTSUPP instead.
v2: Update commit description (Aravind)
Reviewed-by: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
---
drivers/gpu/drm/xe/xe_engine.c | 2 +-
drivers/gpu/drm/xe/xe_mmio.c | 4 ++--
drivers/gpu/drm/xe/xe_sync.c | 6 +++---
drivers/gpu/drm/xe/xe_vm.c | 8 ++++----
drivers/gpu/drm/xe/xe_wait_user_fence.c | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/xe/xe_engine.c b/drivers/gpu/drm/xe/xe_engine.c
index b3036c4a8ec3..74d56c19f8d4 100644
--- a/drivers/gpu/drm/xe/xe_engine.c
+++ b/drivers/gpu/drm/xe/xe_engine.c
@@ -612,7 +612,7 @@ int xe_engine_create_ioctl(struct drm_device *dev, void *data,
if (XE_IOCTL_ERR(xe, e->vm && xe_vm_in_compute_mode(e->vm) !=
!!(e->flags & ENGINE_FLAG_COMPUTE_MODE))) {
- err = -ENOTSUPP;
+ err = -EOPNOTSUPP;
goto put_engine;
}
diff --git a/drivers/gpu/drm/xe/xe_mmio.c b/drivers/gpu/drm/xe/xe_mmio.c
index f7a7f996b37f..f1336803b915 100644
--- a/drivers/gpu/drm/xe/xe_mmio.c
+++ b/drivers/gpu/drm/xe/xe_mmio.c
@@ -495,7 +495,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data,
fallthrough;
case DRM_XE_MMIO_8BIT: /* TODO */
case DRM_XE_MMIO_16BIT: /* TODO */
- ret = -ENOTSUPP;
+ ret = -EOPNOTSUPP;
goto exit;
}
}
@@ -513,7 +513,7 @@ int xe_mmio_ioctl(struct drm_device *dev, void *data,
fallthrough;
case DRM_XE_MMIO_8BIT: /* TODO */
case DRM_XE_MMIO_16BIT: /* TODO */
- ret = -ENOTSUPP;
+ ret = -EOPNOTSUPP;
}
}
diff --git a/drivers/gpu/drm/xe/xe_sync.c b/drivers/gpu/drm/xe/xe_sync.c
index 5acb37a8b2ab..7786b908a3fd 100644
--- a/drivers/gpu/drm/xe/xe_sync.c
+++ b/drivers/gpu/drm/xe/xe_sync.c
@@ -120,7 +120,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef,
switch (sync_in.flags & SYNC_FLAGS_TYPE_MASK) {
case DRM_XE_SYNC_SYNCOBJ:
if (XE_IOCTL_ERR(xe, no_dma_fences && signal))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (XE_IOCTL_ERR(xe, upper_32_bits(sync_in.addr)))
return -EINVAL;
@@ -138,7 +138,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef,
case DRM_XE_SYNC_TIMELINE_SYNCOBJ:
if (XE_IOCTL_ERR(xe, no_dma_fences && signal))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (XE_IOCTL_ERR(xe, upper_32_bits(sync_in.addr)))
return -EINVAL;
@@ -173,7 +173,7 @@ int xe_sync_entry_parse(struct xe_device *xe, struct xe_file *xef,
case DRM_XE_SYNC_USER_FENCE:
if (XE_IOCTL_ERR(xe, !signal))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (XE_IOCTL_ERR(xe, sync_in.addr & 0x7))
return -EINVAL;
diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
index d1c380ad7f6b..be25f05f53c8 100644
--- a/drivers/gpu/drm/xe/xe_vm.c
+++ b/drivers/gpu/drm/xe/xe_vm.c
@@ -1817,10 +1817,10 @@ static int vm_set_error_capture_address(struct xe_device *xe, struct xe_vm *vm,
return -EINVAL;
if (XE_IOCTL_ERR(xe, !(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS)))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
if (XE_IOCTL_ERR(xe, vm->async_ops.error_capture.addr))
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
vm->async_ops.error_capture.mm = current->mm;
vm->async_ops.error_capture.addr = value;
@@ -3068,7 +3068,7 @@ int xe_vm_bind_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
if (VM_BIND_OP(bind_ops[0].op) == XE_VM_BIND_OP_RESTART) {
if (XE_IOCTL_ERR(xe, !(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS)))
- err = -ENOTSUPP;
+ err = -EOPNOTSUPP;
if (XE_IOCTL_ERR(xe, !err && args->num_syncs))
err = EINVAL;
if (XE_IOCTL_ERR(xe, !err && !vm->async_ops.error))
@@ -3093,7 +3093,7 @@ int xe_vm_bind_ioctl(struct drm_device *dev, void *data, struct drm_file *file)
if (XE_IOCTL_ERR(xe, !vm->async_ops.error &&
async != !!(vm->flags & XE_VM_FLAG_ASYNC_BIND_OPS))) {
- err = -ENOTSUPP;
+ err = -EOPNOTSUPP;
goto put_engine;
}
diff --git a/drivers/gpu/drm/xe/xe_wait_user_fence.c b/drivers/gpu/drm/xe/xe_wait_user_fence.c
index 6c8a60c60087..3122374341d6 100644
--- a/drivers/gpu/drm/xe/xe_wait_user_fence.c
+++ b/drivers/gpu/drm/xe/xe_wait_user_fence.c
@@ -143,7 +143,7 @@ int xe_wait_user_fence_ioctl(struct drm_device *dev, void *data,
if (XE_IOCTL_ERR(xe, !vm->async_ops.error_capture.addr)) {
xe_vm_put(vm);
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
}
addr = vm->async_ops.error_capture.addr;
--
2.25.1
More information about the Intel-xe
mailing list