[Intel-xe] [PATCH 2/4] drm/xe: Don't raise error on fused-off media

Gustavo Sousa gustavo.sousa at intel.com
Fri Jun 16 14:18:35 UTC 2023


Quoting Matt Roper (2023-06-14 17:52:00-03:00)
>It's legitimate for the media GMD_ID register to read back as 0x0 if
>media functionality is fused off or otherwise not present on the
>platform.  Avoid printing an "unknown media version" error message for
>this case.
>
>Signed-off-by: Matt Roper <matthew.d.roper at intel.com>

Reviewed-by: Gustavo Sousa <gustavo.sousa at intel.com>

>---
> drivers/gpu/drm/xe/xe_pci.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
>index 7926c2fa1433..b5bea42a458d 100644
>--- a/drivers/gpu/drm/xe/xe_pci.c
>+++ b/drivers/gpu/drm/xe/xe_pci.c
>@@ -465,6 +465,10 @@ static void handle_gmdid(struct xe_device *xe,
> 
>         peek_gmdid(xe, GMD_ID.addr + 0x380000, &ver, media_revid);
> 
>+        /* Media may legitimately be fused off / not present */
>+        if (ver == 0)
>+                return;
>+
>         for (int i = 0; i < ARRAY_SIZE(media_ip_map); i++) {
>                 if (ver == media_ip_map[i].ver) {
>                         xe->info.media_verx100 = ver;
>-- 
>2.40.1
>


More information about the Intel-xe mailing list