[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/pmu: Enable PMU interface

Patchwork patchwork at emeril.freedesktop.org
Mon Jun 19 04:50:58 UTC 2023


== Series Details ==

Series: drm/xe/pmu: Enable PMU interface
URL   : https://patchwork.freedesktop.org/series/119504/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit 9b47915a1aa2b2c58a6109a6bf6bc4d9f3944516
Author: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
Date:   Mon Jun 19 10:21:28 2023 +0530

    drm/xe/pmu: Enable PMU interface
    
    There are a set of engine group busyness counters provided by HW which are
    perfect fit to be exposed via PMU perf events.
    
    BSPEC: 46559, 46560, 46722, 46729
    
    events can be listed using:
    perf list
      xe_0000_03_00.0/any-engine-group-busy-gt0/         [Kernel PMU event]
      xe_0000_03_00.0/copy-group-busy-gt0/               [Kernel PMU event]
      xe_0000_03_00.0/interrupts/                        [Kernel PMU event]
      xe_0000_03_00.0/media-group-busy-gt0/              [Kernel PMU event]
      xe_0000_03_00.0/render-group-busy-gt0/             [Kernel PMU event]
    
    and can be read using:
    perf stat -e "xe_0000_03_00.0/render-group-busy-gt0/" -I 1000
               time             counts unit events
         1.001343319                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
         2.011523336                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
         3.014168811                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
         4.016671838                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
         5.018363448                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
         6.020125417 18446743376875220992 ns xe_0000_03_00.0/render-group-busy-gt0/
         7.021584533 18446744073708230656 ns xe_0000_03_00.0/render-group-busy-gt0/
         8.029878236       696835650983 ns xe_0000_03_00.0/render-group-busy-gt0/
         9.032367313                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
        10.034799448                  0 ns xe_0000_03_00.0/render-group-busy-gt0/
    
    The pmu base implementation is taken from i915.
    
    Co-developed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
    Co-developed-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
    Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty at intel.com>
+ /mt/dim checkpatch 8bf305693c7aa4cadfa30d28ce9ed635711142d3 drm-intel
0c7f872ab drm/xe: Get GT clock to nanosecs
9b47915a1 drm/xe/pmu: Enable PMU interface
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 6, in <module>
    from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#22: 
     1.001343319                  0 ns xe_0000_03_00.0/render-group-busy-gt0/

-:35: WARNING:BAD_SIGN_OFF: Co-developed-by: must be immediately followed by Signed-off-by:
#35: 
Co-developed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Co-developed-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>

-:36: WARNING:BAD_SIGN_OFF: Co-developed-by and Signed-off-by: name/email do not match
#36: 
Co-developed-by: Bommu Krishnaiah <krishnaiah.bommu at intel.com>
Signed-off-by: Aravind Iddamsetty <aravind.iddamsetty at intel.com>

-:173: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#173: 
new file mode 100644

-:178: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#178: FILE: drivers/gpu/drm/xe/xe_pmu.c:1:
+/*

-:179: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#179: FILE: drivers/gpu/drm/xe/xe_pmu.c:2:
+ * SPDX-License-Identifier: MIT

-:640: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#640: FILE: drivers/gpu/drm/xe/xe_pmu.c:463:
+	XE_BUG_ON(!pmu->base.event_init);

-:654: WARNING:AVOID_BUG: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants
#654: FILE: drivers/gpu/drm/xe/xe_pmu.c:477:
+	XE_BUG_ON(!pmu->base.event_init);

total: 0 errors, 8 warnings, 0 checks, 831 lines checked




More information about the Intel-xe mailing list