[Intel-xe] ✗ CI.checkpatch: warning for drm/xe/mmio: update gt_count when probing multi-tile

[Patchwork]

== Series Details ==

Series: drm/xe/mmio: update gt_count when probing multi-tile
URL   : https://patchwork.freedesktop.org/series/119878/
State : warning

== Summary ==

+ KERNEL=/kernel
+ git clone https://gitlab.freedesktop.org/drm/maintainer-tools mt
Cloning into 'mt'...
warning: redirecting to https://gitlab.freedesktop.org/drm/maintainer-tools.git/
+ git -C mt rev-list -n1 origin/master
c7d32770e3cd31d9fc134ce41f329b10aa33ee15
+ cd /kernel
+ git config --global --add safe.directory /kernel
+ git log -n1
commit a7e9bab973eddbd6971432b9073ecf6b9a972556
Author: Matthew Auld <matthew.auld at intel.com>
Date:   Mon Jun 26 18:09:06 2023 +0100

    drm/xe/mmio: update gt_count when probing multi-tile
    
    It looks like the single-tile PVC in CI dies during module load when doing
    the pcode init. From the logs we try to access the address
    0000000000138124 which doesn't map to anything, however 0x138124 also
    looks to be the PCODE_MAILBOX register. So looks like the per-tile
    mmio register mapping is NULL.
    
    During probe the tile count is potentially trimmed, since we don't know
    the real count until we actually probe the device. This seems to be
    the case for single-tile PVC or similar devices.  However it looks like
    the gt_count is never adjusted to respect this updated tile count. As a
    result when later doing some for_each_gt() loop, like we do for the
    pcode, we can get back some GT that maps to some non-existent tile
    which hasn't been properly set up, leading to crashes.
    
    Try to fix this by adjusting the gt_count after probing the tiles for
    real.
    
    Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/383
    Signed-off-by: Matthew Auld <matthew.auld at intel.com>
    Cc: Lucas De Marchi <lucas.demarchi at intel.com>
    Cc: Matt Roper <matthew.d.roper at intel.com>
+ /mt/dim checkpatch d3fc5af59c7c17ad1a0272c49dbff84534d9d606 drm-intel
a7e9bab97 drm/xe/mmio: update gt_count when probing multi-tile
-:23: WARNING:COMMIT_LOG_USE_LINK: Unknown link reference 'Closes:', use 'Link:' instead
#23: 
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/383

total: 0 errors, 1 warnings, 0 checks, 12 lines checked