[Intel-xe] [PATCH v12 04/13] drm/xe/guc_pc: add missing mem_access for freq_rpe_show

[Gupta, Anshuman]

> -----Original Message-----
> From: Auld, Matthew <matthew.auld at intel.com>
> Sent: Monday, June 26, 2023 4:21 PM
> To: intel-xe at lists.freedesktop.org
> Cc: Brost, Matthew <matthew.brost at intel.com>; Vivi, Rodrigo
> <rodrigo.vivi at intel.com>; Gupta, Anshuman <anshuman.gupta at intel.com>
> Subject: [PATCH v12 04/13] drm/xe/guc_pc: add missing mem_access for
> freq_rpe_show
> 
> The mem_access is meant to cover any kind of device level memory access,
> mmio included.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Matthew Brost <matthew.brost at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Anshuman Gupta <anshuman.gupta at intel.com>
> ---
>  drivers/gpu/drm/xe/xe_guc_pc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 5d5cf4b0d508..e3722a805837 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c
> @@ -430,8 +430,12 @@ static ssize_t freq_rpe_show(struct device *dev,
>  			     struct device_attribute *attr, char *buf)  {
>  	struct xe_guc_pc *pc = dev_to_pc(dev);
> +	struct xe_gt *gt = pc_to_gt(pc);
> +	struct xe_device *xe = gt_to_xe(gt);
> 
> +	xe_device_mem_access_get(xe);
What is desirable to use here , xe_pm_runtime_get() or  xe_device_mem_access_get() ?
It is register mmio access
Few places in driver using xe_pm_runtime_get() for mmio access.
Thanks,
Anshuman Gupta.
>  	pc_update_rp_values(pc);
> +	xe_device_mem_access_put(xe);
>  	return sysfs_emit(buf, "%d\n", pc->rpe_freq);  }  static
> DEVICE_ATTR_RO(freq_rpe);
> --
> 2.41.0