[Intel-xe] [PATCH 1/2] drm/xe/kunit: Handle fake device creation for all platform/subplatform cases

Lucas De Marchi lucas.demarchi at intel.com
Tue Jun 27 19:31:44 UTC 2023


On Tue, Jun 13, 2023 at 11:30:46AM -0700, Anusha Srivatsa wrote:
>For platform like Alderlake P there are subplatforms and
>just Alderlake P. Unlike DG2 in which every flavour is
>either a G10,G11 or G12 variant. In this case(Alderlake P/S),
>the Kunit test evaluates the subplatform to NONE and is
>unable to create a fake device. Removing the condition
>in xe_pci_fake_device_init() to support this corner case
>so driver can proceed with the unit testing.
>
>Cc: Lucas De Marchi <lucas.demarchi at intel.com>
>Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>
>Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

both patches applied, thanks.

Lucas De Marchi

>---
> drivers/gpu/drm/xe/tests/xe_pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
>index 2178ad71c0da..a40879da2fbe 100644
>--- a/drivers/gpu/drm/xe/tests/xe_pci.c
>+++ b/drivers/gpu/drm/xe/tests/xe_pci.c
>@@ -139,9 +139,6 @@ int xe_pci_fake_device_init(struct xe_device *xe, enum xe_platform platform,
> 		if (subplatform_desc->subplatform == subplatform)
> 			break;
>
>-	if (subplatform == XE_SUBPLATFORM_NONE && subplatform_desc)
>-		return -ENODEV;
>-
> 	if (subplatform != XE_SUBPLATFORM_NONE && !subplatform_desc)
> 		return -ENODEV;
>
>-- 
>2.25.1
>


More information about the Intel-xe mailing list